Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video only on active scene #982

Merged

Conversation

BPerlakiH
Copy link
Collaborator

Fixes: #978

For some unknown reasons, SwiftUI is triggering the (formerly used) .onAppear callback even if the application is in the background.

Changing that to observing, when the application becomes active, solves this issue.

I have tested it with the video in the ticket both on iPad 17, and macOS.
iPhone testing was omitted, as the changed file is not used there.

@BPerlakiH BPerlakiH added this to the 3.6.0 milestone Sep 17, 2024
@BPerlakiH BPerlakiH linked an issue Sep 17, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 37.14%. Comparing base (9093134) to head (a63f301).

Files with missing lines Patch % Lines
Views/BrowserTab.swift 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
- Coverage   37.23%   37.14%   -0.10%     
==========================================
  Files         111      111              
  Lines        6346     6348       +2     
==========================================
- Hits         2363     2358       -5     
- Misses       3983     3990       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 merged commit fda4e82 into main Sep 18, 2024
4 checks passed
@kelson42 kelson42 deleted the 978-video-play-briefly-when-backgrounding-and-foregrounding branch September 18, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video play briefly when backgrounding and foregrounding
3 participants