Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move deleteDownloadTask to be after file opened #998

Conversation

BPerlakiH
Copy link
Collaborator

Fixes: #992

The main issue was that the UI listened to the download task, that is in progress, if it is not existing the UI will return to the initial state (the file is downloadable). Once the downloaded file is moved and opened (which is async now), the "Open Main Page" will be displayed on the UI.

Solution:
Move the delete download task after the file has been opened, this will keep the UI in the progress state.

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 38.00%. Comparing base (2ff9049) to head (739af80).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
Model/DownloadService.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #998      +/-   ##
==========================================
- Coverage   39.98%   38.00%   -1.99%     
==========================================
  Files         114      114              
  Lines        6470     6471       +1     
==========================================
- Hits         2587     2459     -128     
- Misses       3883     4012     +129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 merged commit 197d8d5 into main Oct 5, 2024
4 checks passed
@kelson42 kelson42 deleted the 992-large-download-wikipedia_en_all_maxi-does-not-complete-after-99 branch October 5, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large download (wikipedia_en_all_maxi) does not complete after 99%
3 participants