feat: add moq-sub to subscribe to media from moq relays #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kixelated
approved these changes
Feb 20, 2024
| while let Some(fragment) = segment.fragment().await? { | ||
| trace!("segment={} fragment={}", segment.sequence, fragment.sequence); | ||
| let buf = Self::recv_fragment(fragment).await?; | ||
| out.lock().await.write_all(&buf).await?; |
There was a problem hiding this comment.
Seems fine although we will need to handle this better eventually. MoQ is meant to be lossy.
There was a problem hiding this comment.
The segments are already received in parallel. Your suggestion would be to also receive fragments in parallel?
There was a problem hiding this comment.
Unfortunately, the fragments need to be written in order for playback to work. We either need separate files for each segment (like HLS/DASH), or drop the previous segment on each new segment. The current code will interleave fragments from different segments which won't playback.
|
Feel free to merge this and my other PR :) I am not working on these further for the time being. |
|
Working on updating this to the new API. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple
moq-subtool which allows to connect to a moq relay and subscribe to a broadcast. It expects the format as published bymoq-pub, and will then dump the first video and first audio track to stdout. By pipingmoq-subinto e.g.ffplayyou can play media from a moq relay.Also includes a
dev/subscript that works without further arguments when usingdev/relayanddev/pub.Also added an optional
AUDIO=1env var todev/pubto not skip audio tracks.