Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose moq-pub as library with generic input #134

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

Frando
Copy link
Contributor

@Frando Frando commented Feb 12, 2024

This PR has two changes, which allow to reuse the code in moq-pub from other libraries or apps:

  • adds a lib.rs to moq-pub to expose the media module
  • lets the Media struct accept an input: impl AsyncRead argument instead of being hardcoded to stdin

@kixelated
Copy link
Owner

although there be a LINT FAILURE.

@Frando
Copy link
Contributor Author

Frando commented Feb 26, 2024

The failure seems unrelated to me?


error: unused import: `string::*`
Error:   --> moq-transport/src/coding/mod.rs:10:9
   |
10 | pub use string::*;
   |         ^^^^^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`

@kixelated kixelated merged commit ad5cc5d into kixelated:main Mar 7, 2024
1 check passed
@kixelated
Copy link
Owner

Sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants