Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper state management #143

Merged
merged 8 commits into from
Apr 1, 2024
Merged

Proper state management #143

merged 8 commits into from
Apr 1, 2024

Conversation

kixelated
Copy link
Owner

Easily the most difficult part of this project has been how to handle state cleanup. Rust futures are not guaranteed to execute, so the code has to be littered with Drop traits everywhere to ensure we could cleanup at any point. This get extremely difficult when combined with the borrow checker, as often a child needs a reference to the parent to clean up a cache entry or whatever.

I spent a while but I think I've got something pretty solid. The core is the State helper that is like a fancy RWMutex. It's split into two halves that can be independently dropped, allowing us to track when the producer and all consumers are dropped. You can read at any time, but you can only wait or lock mutably when it's not dropped, preventing tasks from running when the other side is gone.

I added back the multi-origin support and it should now correctly handle things like deduplication and removing announces. Who knows though the code is really hard to reason about.

@kixelated kixelated merged commit a70f645 into main Apr 1, 2024
1 check passed
@kixelated kixelated deleted the drop-drop branch April 1, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant