Support generating multiple videotracks and single audio from from a mp4 file using FFmpeg #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mp4 file using FFmpeg (#6) * committosupport-generatingMultipleVideotracksFromaSinglefileusingFFmpeg * committosupport-generatingMultipleVideotracksFromaSinglefileusingFFmpeg2
|
UT VideoTrack-swap-UT.mp4 |
|
Oh wow sorry somehow I missed this PR. I'll take a look at it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Luke @kixelated , in context to the PR in
moq-js, this PR holds the changes done to./dev/pubto enable us to create 3 video renditions for a video file that could be ingested for a single namespace viamoq-pub.I have tried to optimize FFmpeg args to help us get the best of video quality and latency and also tried to make the config parameters in the script readable, at times occasionally I have observed video artefacts at higher video quality track. Since the context is the same I added the changes in
./dev/pub, please let me know if you would like me to keep this as a separate file like./dev/pub_multiScript usage scenarios:
With "multi" mode enabled, a realtime live video track stream will be simulated and the video will be watermarked/overlayed with real-time UTC clock from the server on the top left corner that can be visually compared with https://time.is/UTC to check real-time latency and the videoresolition-bitrate will be watermarked/overlayed at the bottom right corner to assist in visually identifying the track.
./dev/pubscript had an "$@" as the last argument tomoq-pub, which passes all the arguments to the script tomoq-pub, had to remove it to incorporate the current implementation and legacy flow works without it, to my understanding moq-pub usage ismoq-pub --name <NAME> <URL>, so we can safely remove "$@" . Kindly advise if I overlooked this.Kindly review and let me know your thoughts and amendments to be done.