Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: post evaluate cell text (jupytext percent format with python multi-line string) #68

Merged
merged 7 commits into from
Mar 13, 2023

Conversation

kiyoon
Copy link
Owner

@kiyoon kiyoon commented Mar 13, 2023

This PR adds support for Jupytext-style markdown cell with multi-line python string.

# %% [md]
"""
# markdown header
markdown content
"""

Implementation detail:

  • Previously, we processed the cell content as we are getting updates from neovim buffer change events.
  • This PR will evaluate and manipulate the content afterwards (i.e. just before it will be sent to Jupyter Notebook)

This might have a minor performance issue, but it will be more stable to do this anyway.

This may close #64 and #44.

Additionally, this fixes #65 (creating "markdown (jupytext)" cell but it's supposed to be "markdown" cell in Notebook.)

@kiyoon kiyoon merged commit 5e8cddd into master Mar 13, 2023
@kiyoon kiyoon deleted the feat/post-eval-cell-text branch June 15, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating Jupytext markdown cells can cause notebook to crash MD cells don't close at end of file
1 participant