fix!: Notebook 7 uses localhost:8888/nbclassic #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that we currently don't have any other options, or we could simply restrict the installation of the notebook to version 6.5.4. It doesn't appear that nbclassic would bring us any benefits, right? |
|
As far as I know, nbclassic will be maintained for another 2 years. And there may be people who actually want to use Notebook 7 and we don't want them to uninstall it just for Jupynium. |
|
So one modify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, users who install notebook will install Notebook 7 by default. Thus, this PR changes the default options so that it will work with URL
http://localhost:8888/nbclassic.Make sure to install
pip install --upgrade notebook nbclassic