Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple runs may target frames from last run if .ocrvid/frames/ is not cleaned up #9

Closed
kj-9 opened this issue Jan 29, 2024 · 3 comments

Comments

@kj-9
Copy link
Owner

kj-9 commented Jan 29, 2024

current behavior: saving frames at .ocrvid/frames/${video_name} for each run, without removing last run.

this cause duplication if runs multiple times, changing frames-step option.

@kj-9 kj-9 changed the title cleanup .ocrvid/frames/ for multiple run multiple runs may target frames from last run if .ocrvid/frames/ is not cleaned up Jan 29, 2024
@kj-9
Copy link
Owner Author

kj-9 commented Jan 29, 2024

it might be better to not save frames by default?

leave it an option and make users choose. users can save frames if they want, clean up frames after run if they want.

but ensure each run is run on unique frames generated from the input video.
We can use buffer not file to pass to vision framework using initWithData
e.g. here or here

@kj-9
Copy link
Owner Author

kj-9 commented Jan 29, 2024

as side effect, in output json

  • .frames_dir is deleted
  • .frames_step is deleted
  • .frames[].frame_files is deleted, .frames[].frame_index is added instead.
スクリーンショット 2024-01-30 0 14 47

kj-9 added a commit that referenced this issue Jan 29, 2024
kj-9 added a commit that referenced this issue Jan 29, 2024
kj-9 added a commit that referenced this issue Jan 29, 2024
@kj-9 kj-9 closed this as completed Jan 29, 2024
@kj-9 kj-9 reopened this Jan 29, 2024
@kj-9
Copy link
Owner Author

kj-9 commented Jan 29, 2024

json in readme is not up to date

kj-9 added a commit that referenced this issue Jan 30, 2024
@kj-9 kj-9 closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant