Add SetSectorSize test in SCSIHD

Follow-up on PiSCSI#1402, PiSCSI#1405, PiSCSI#1427 This is the first (yet incomplete) test to cover this behavior. Signed-off-by: Klaus Kämpf <kkaempf@gmail.com>
kkaempf · Apr 1, 2024 · 09ea598 · 09ea598
1 parent b1a3ffb
commit 09ea598
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/cpp/test/mocks.h b/cpp/test/mocks.h
@@ -363,6 +363,8 @@ class MockSCSIHD : public SCSIHD //NOSONAR Ignore inheritance hierarchy depth in
 	FRIEND_TEST(ScsiHdTest, DECSpecialFunctionControlPage);
 	FRIEND_TEST(ScsiHdTest, GetSectorSizes);
 	FRIEND_TEST(ScsiHdTest, ModeSelect);
+	FRIEND_TEST(ScsiHdTest, SetSectorSize);
+
 	FRIEND_TEST(PiscsiExecutorTest, SetSectorSize);
 
 public:

diff --git a/cpp/test/scsihd_test.cpp b/cpp/test/scsihd_test.cpp
@@ -140,3 +140,16 @@ TEST(ScsiHdTest, ModeSelect)
 	buf[20] = 0x02;
 	EXPECT_NO_THROW(hd.ModeSelect(scsi_command::eCmdModeSelect10, cmd, buf, 255)) << "MODE SELECT(10) is supported";
 }
+
+// Test for the ModeSelect6 to set sector size to 512 (issued by the DEC Alpha SRM console)
+TEST(ScsiHdTest, SetSectorSize)
+{
+	MockSCSIHD hd(0, false);
+	vector<int> cmd = { 0x15, 0x10, 0x00, 0x00, 0x0c, 0x00 };
+	vector<uint8_t> buf = { 0x00, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0x00 };
+
+	hd.SetSectorSizeInBytes(4096);
+
+	EXPECT_NO_THROW(hd.ModeSelect(scsi_command::eCmdModeSelect6, cmd, buf, buf.size())) << "Set sector size is supported";
+	// FIXME: EXPECT_EQ(9, hd.GetSectorSizeShiftCount()) << "Set sector size to 512";
+}