Improve condition checks

kkamara · Feb 6, 2022 · a76ac72 · a76ac72
1 parent a35d064
commit a76ac72
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/app/Helpers/RedisCartHelper.php b/app/Helpers/RedisCartHelper.php
@@ -24,7 +24,7 @@ public function __construct(protected ?Client $client = null) {
      * @return Mixed
      */
     public function get($key): mixed {
-        if (!$this->client->exists($key)) {
+        if (0 === $this->client->exists($key)) {
             return null;
         }
         $result = $this->client->get($key);
@@ -50,7 +50,7 @@ public function set($key, $value): mixed {
      * @return Integer
      */
     public function del(string $keys): int {
-        if (!$this->client->exists($keys)) {
+        if (0 === $this->client->exists($keys)) {
             return 0;
         }
         return $this->client->del($keys);
@@ -66,7 +66,7 @@ public function getRedisCart(): mixed {
     /**
      * @return Mixed
      */
-    public function getGuestIdentifier(): string {
+    private function getGuestIdentifier(): string {
         return fingerprint();
     }
 

diff --git a/app/Http/Controllers/HomeController.php b/app/Http/Controllers/HomeController.php
@@ -4,18 +4,14 @@
 
 use Illuminate\Http\Request;
 use App\Models\Product\Product;
-use App\Helpers\RedisCartHelper;
 
 class HomeController extends Controller
 {
     /**
      * @param Product $product
      * @param RedisCartHelper $redisClient
      */
-    public function __construct(
-        protected Product $product = new Product,
-        protected RedisCartHelper $redisClient = new RedisCartHelper,
-    ) {}
+    public function __construct(protected Product $product = new Product) {}
 
     /**
      * Show the application dashboard.