Remove dependency on unmaintained fs2 #505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: rustyline on master is 📦 v8.0.0 via 🦀 v1.50.0
❯ redoxer check
Checking fs2 v0.4.3
error[E0425]: cannot find function `allocate` in module `sys`
--> /home/coolreader18/.cargo/registry/src/gh.neting.cc-1ecc6299db9ec823/fs2-0.4.3/src/lib.rs:104:14
|
104 | sys::allocate(self, len)
| ^^^^^^^^ not found in `sys`
error: aborting due to previous error
Now: rustyline on no-fs2 is 📦 v8.0.0 via 🦀 v1.50.0
❯ redoxer check
Checking rustyline v8.0.0 (/home/coolreader18/rustyline)
Finished dev [unoptimized + debuginfo] target(s) in 0.38s
|
|
Thanks. |
|
@coolreader18 It seems that fs3, a fork of fs2 has the same issue. |
|
@coolreader18 Would you mind giving fd-lock a try ? See #507 |
|
I let you close this PR. |
|
Version 8.1.0 released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs2 hasn't made a release in 3 years, and it looks like we only need it for file locking, which is pretty easy to do ourselves. Plus, this fixes compilation on Redox (danburkert/fs2-rs#38)