Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid panic: entry[pos..] => entry.get(pos..) #776

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lengyijun
Copy link

No description provided.

@gwenn
Copy link
Collaborator

gwenn commented May 1, 2024

I may be wrong but:
We have:

        if line.is_empty() || pos < line.len() {
            return None;
        }

So pos == line.len() && pos > 0.
So I guess that the panic can happen only if history returns an entry that doesn't start with line.
Which seems fine to me.

@gwenn gwenn added the invalid label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants