-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rpc docker image for hive testing #454
feat: add rpc docker image for hive testing #454
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
===========================================
+ Coverage 23.17% 72.66% +49.49%
===========================================
Files 9 44 +35
Lines 1247 3977 +2730
===========================================
+ Hits 289 2890 +2601
- Misses 958 1087 +129
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice pr !! a few questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @Eikix ! I removed the deployer and instead compiling the contracts before dumping so we're sure it's the latest
Good job! |
7fcebdf
to
fa9decf
Compare
fa9decf
to
b128384
Compare
…-docker-for-hive-testing
SystemMD is not available on our docker container! Setting it up will be adding more complexity than doing bash scripts! |
…-docker-for-hive-testing
…-docker-for-hive-testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, waiting for the two questions
…-docker-for-hive-testing
Time spent on this PR: 1
Resolves: #350 #451
Pull Request type
Please check the type of change your PR introduces:
What is the new behavior?
Here's a screenshot of checking the class hash of deployed Kakarot contract in Madara inside the docker container. It corresponds to the computed class-hash
Does this introduce a breaking change?
Added changes to
CHANGELOG.md