Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upload katana dump #489

Merged
merged 23 commits into from
Aug 29, 2023
Merged

Conversation

greged93
Copy link
Collaborator

This PR uploads the Katana dump as an artifact for use.

Time spent on this PR: 0.3 day

(Partly) Resolves: kkrt-labs/ef-tests#22

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

The katana dump gets uploaded as an artifact on push to main.

Does this introduce a breaking change?

  • Yes
  • No

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 83.25% and project coverage change: +49.18% 🎉

Comparison is base (71506a8) 23.17% compared to head (4b4c1f8) 72.35%.
Report is 189 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #489       +/-   ##
===========================================
+ Coverage   23.17%   72.35%   +49.18%     
===========================================
  Files           9       44       +35     
  Lines        1247     3994     +2747     
===========================================
+ Hits          289     2890     +2601     
- Misses        958     1104      +146     
Files Changed Coverage Δ
crates/core/src/mock/serde.rs 0.00% <0.00%> (ø)
crates/core/src/models/transaction.rs 93.63% <ø> (ø)
crates/core/src/models/transaction_receipt.rs 97.02% <ø> (ø)
crates/core/src/test_utils/bin/dump-katana.rs 0.00% <ø> (ø)
crates/core/src/test_utils/deploy_helpers.rs 32.44% <ø> (ø)
crates/core/src/test_utils/execution_helpers.rs 100.00% <ø> (ø)
crates/core/src/test_utils/fixtures.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/alchemy_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/eth_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/net_api.rs 100.00% <ø> (ø)
... and 34 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ClementWalter ClementWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the artifacts.yml workflow

@greged93 greged93 added this pull request to the merge queue Aug 29, 2023
Merged via the queue into kkrt-labs:main with commit d2089f5 Aug 29, 2023
7 checks passed
@greged93 greged93 deleted the feat/upload-katana-dump branch August 29, 2023 09:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: add flow for katana dump
2 participants