Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove quotes in sha #510

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

greged93
Copy link
Collaborator

@greged93 greged93 commented Sep 1, 2023

Removes the quotes from the generated kakarot_sha file.

Time spent on this PR: NA

Resolves: #NA

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

Generated katana dump comes with a sha file. This PR removes the quotes.

Does this introduce a breaking change?

  • Yes
  • No

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 83.25% and project coverage change: +49.30% 🎉

Comparison is base (71506a8) 23.17% compared to head (6f9463c) 72.48%.
Report is 200 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #510       +/-   ##
===========================================
+ Coverage   23.17%   72.48%   +49.30%     
===========================================
  Files           9       44       +35     
  Lines        1247     3987     +2740     
===========================================
+ Hits          289     2890     +2601     
- Misses        958     1097      +139     
Files Changed Coverage Δ
crates/core/src/mock/serde.rs 0.00% <0.00%> (ø)
crates/core/src/models/transaction.rs 93.63% <ø> (ø)
crates/core/src/models/transaction_receipt.rs 97.02% <ø> (ø)
crates/core/src/test_utils/bin/dump-katana.rs 0.00% <ø> (ø)
crates/core/src/test_utils/deploy_helpers.rs 32.44% <ø> (ø)
crates/core/src/test_utils/execution_helpers.rs 100.00% <ø> (ø)
crates/core/src/test_utils/fixtures.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/alchemy_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/eth_api.rs 100.00% <ø> (ø)
crates/eth-rpc/src/api/net_api.rs 100.00% <ø> (ø)
... and 34 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greged93 greged93 added this pull request to the merge queue Sep 1, 2023
Merged via the queue into kkrt-labs:main with commit cbfd840 Sep 1, 2023
9 checks passed
@greged93 greged93 deleted the fix/kakarot-sha branch September 1, 2023 09:37
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants