Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump lib/kakarot from 5822210 to dadc319 #688

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 4, 2024

Bumps lib/kakarot from 5822210 to dadc319.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

This change is Reviewable

Bumps [lib/kakarot](https://github.com/kkrt-labs/kakarot) from `5822210` to `dadc319`.
- [Release notes](https://github.com/kkrt-labs/kakarot/releases)
- [Commits](kkrt-labs/kakarot@5822210...dadc319)

---
updated-dependencies:
- dependency-name: lib/kakarot
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Change in project dependencies. label Jan 4, 2024
@dependabot dependabot bot requested a review from Eikix as a code owner January 4, 2024 23:27
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 732 lines in your changes are missing coverage. Please review.

Comparison is base (71506a8) 23.17% compared to head (a3d3e40) 69.03%.
Report is 257 commits behind head on main.

Files Patch % Lines
src/starknet_client/mod.rs 51.81% 212 Missing ⚠️
src/eth_rpc/servers/eth_rpc.rs 27.01% 208 Missing ⚠️
src/starknet_client/config.rs 17.24% 72 Missing ⚠️
src/starknet_client/errors.rs 10.00% 36 Missing ⚠️
src/main.rs 0.00% 30 Missing ⚠️
src/starknet_client/helpers.rs 47.27% 29 Missing ⚠️
src/models/call.rs 90.34% 17 Missing ⚠️
src/models/transaction/transaction.rs 83.33% 17 Missing ⚠️
src/bin/dump-genesis.rs 0.00% 16 Missing ⚠️
src/eth_rpc/servers/net_rpc.rs 16.66% 15 Missing ⚠️
... and 17 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #688       +/-   ##
===========================================
+ Coverage   23.17%   69.03%   +45.85%     
===========================================
  Files           9       34       +25     
  Lines        1247     2364     +1117     
===========================================
+ Hits          289     1632     +1343     
+ Misses        958      732      -226     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 5, 2024

Superseded by #691.

@dependabot dependabot bot closed this Jan 5, 2024
@dependabot dependabot bot deleted the dependabot/submodules/lib/kakarot-dadc319 branch January 5, 2024 23:06
anukkrit149 pushed a commit to karnotxyz/kakarot-rpc that referenced this pull request Aug 9, 2024
Time spent on this PR: 2.5

## Pull request type

Please check the type of change your PR introduces:

- [ ] Bugfix
- [x] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):

## What is the current behavior?

Every opcode makes real changes to contract storages.
This is harder to revert and more expensive in steps.

## What is the new behavior?

A local `State` is created in the beginning of a tx/ExecutionContext and
used
as a buffer for SSTORE/SLOAD/BALANCE.

Changes are committed or discarded at the end in `finalize`.

The split between `ExecutionContext` and `CallContext` has been reviewed
to put in the `CallContext` every constants
parts of the `ExecutionContext`, ie parameters/values set at init and
not changed afterwards.

Resolves: kkrt-labs#770 kkrt-labs#726 kkrt-labs#690 kkrt-labs#689 kkrt-labs#688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Change in project dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants