Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add health endpoint #752

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

apoorvsadana
Copy link
Contributor

@apoorvsadana apoorvsadana commented Feb 2, 2024

  1. Add a get /health endpoint
  2. Add poetry version to Dockerfile as it installs an older version without that

This change is Reviewable

Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 520 lines in your changes are missing coverage. Please review.

Comparison is base (71506a8) 23.17% compared to head (4189d1d) 66.05%.
Report is 281 commits behind head on main.

Files Patch % Lines
src/eth_rpc/servers/eth_rpc.rs 1.65% 178 Missing ⚠️
src/eth_provider/provider.rs 67.55% 110 Missing ⚠️
src/config.rs 0.00% 81 Missing ⚠️
src/main.rs 0.00% 37 Missing ⚠️
src/test_utils/eoa.rs 81.19% 22 Missing ⚠️
src/eth_rpc/servers/net_rpc.rs 16.66% 15 Missing ⚠️
src/models/felt.rs 87.03% 14 Missing ⚠️
src/eth_rpc/servers/web3_rpc.rs 9.09% 10 Missing ⚠️
src/eth_provider/error.rs 0.00% 8 Missing ⚠️
src/models/block.rs 74.07% 7 Missing ⚠️
... and 15 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #752       +/-   ##
===========================================
+ Coverage   23.17%   66.05%   +42.88%     
===========================================
  Files           9       36       +27     
  Lines        1247     1532      +285     
===========================================
+ Hits          289     1012      +723     
+ Misses        958      520      -438     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eikix Eikix added this pull request to the merge queue Feb 2, 2024
Merged via the queue into kkrt-labs:main with commit b499179 Feb 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants