Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: use checked math #1009

Merged
merged 1 commit into from
Oct 2, 2024
Merged

dev: use checked math #1009

merged 1 commit into from
Oct 2, 2024

Conversation

enitrat
Copy link
Contributor

@enitrat enitrat commented Oct 2, 2024 •
edited
Loading

uses checked math to prevent eventual overflow risks.
this should not be more costly then regular maths (which abstract the result management with an .expect())

This change is Reviewable

@enitrat enitrat requested a review from ClementWalter as a code owner October 2, 2024 11:30
@enitrat enitrat merged commit dcbb421 into main Oct 2, 2024
4 of 5 checks passed
@enitrat enitrat deleted the dev/checked-math branch October 2, 2024 12:30
saimeunt pushed a commit to saimeunt/kakarot-ssj that referenced this pull request Oct 2, 2024
@enitrat @saimeunt
dev: use checked math (kkrt-labs#1009)
8e6434a
enitrat added a commit that referenced this pull request Oct 2, 2024
@saimeunt @enitrat
test: get_starknet_address (#1006)
7048c0d 
* test_kakarot_core_get_starknet_address

* ci: downgrade cairo native (#1008)

* dev: use checked math (#1009)

* fix get_starknet_address test

---------

Co-authored-by: Mathieu <60658558+enitrat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@enitrat