Fix scrollspy on link clicking, and # for top of page (mmistakes#2023)

kkunapuli · Jan 15, 2019 · 0aa8e14 · 0aa8e14
1 parent 225140a
commit 0aa8e14
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/assets/js/_main.js b/assets/js/_main.js
@@ -82,7 +82,7 @@ $(document).ready(function() {
   $(window).scroll(jQuery.throttle(250, function() {
     // Don't run while smooth scrolling (from clicking on a link).
     if (smoothScrolling) return;
-    var scrollTop = $(window).scrollTop() + 20;  // 20 = offset
+    var scrollTop = $(window).scrollTop() + 20 + 1;  // 20 = offset
     var links = [];
     $("nav.toc a").each(function() {
       var link = $(this);
@@ -106,9 +106,12 @@ $(document).ready(function() {
         if (links[i].href !== location.hash) {
           history.replaceState(null, null, links[i].href);
         }
-        break;
+        return;
       }
     }
+    if ('#' !== location.hash) {
+      history.replaceState(null, null, '#');
+    }
   }));
 
   // add lightbox class to all image links