Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default argument to get_reactions_kcat_mapping #7

Closed
yaccos opened this issue Oct 12, 2020 · 1 comment
Closed

Add default argument to get_reactions_kcat_mapping #7

yaccos opened this issue Oct 12, 2020 · 1 comment

Comments

@yaccos
Copy link
Contributor

yaccos commented Oct 12, 2020

When using get_reactions_kcat_mapping, you may not have any user-defined protein database. Hence, requiring the argument protein_kcat_database_path to have a value is therefore counterintuitive. From inspecting the function, I find that supplying an empty string as the value will make the function ignore the database. I therefore suggest having the empty string as the default argument for protein_kcat_database_path.

Paulocracy added a commit that referenced this issue Oct 13, 2020
@Paulocracy
Copy link
Member

I (once again :-) agree with you and added a default parameter.

@yaccos yaccos closed this as completed Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants