Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize case before searching. #111

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Normalize case before searching. #111

merged 2 commits into from
Jan 22, 2019

Conversation

jalandis
Copy link
Contributor

Fixes #110

I am using toLocaleLowerCase() vs toLowerCase() as I found it recommended for international support (Turkish language examples in MDN documenation). If there is any reason to prefer toLowerCase(), please let me know and I will update the pull request

Test Case (Same results for both searches):

tb -t Create Jira ticket
tb -f Jira
tb -f jira

@klaudiosinani klaudiosinani self-requested a review January 22, 2019 17:34
@klaudiosinani klaudiosinani added the enhancement New feature or request label Jan 22, 2019
klaudiosinani
klaudiosinani approved these changes Jan 22, 2019
View reviewed changes
Copy link
Owner

@klaudiosinani klaudiosinani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you for taking the time to contribute!

@klaudiosinani klaudiosinani merged commit aaf244f into klaudiosinani:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaudiosinani klaudiosinani klaudiosinani approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jalandis @klaudiosinani