Use .config directory for taskbook.json #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it can't be specified dynamically, it is nice to have config files located in the ~/.config directory. This follows the standard used by many thousands of other programs and prevents the homedir from getting unreasonably cluttered with configs. Docs still need to be updated.
chocolateboy
suggested changes
Aug 5, 2018
There was a problem hiding this comment.
I would suggest using ${XDG_CONFIG_HOME:-~/.config} (via e.g. xdg-basedir), rather than hardwiring the path.
Also, it should be noted that this convention is specific to Linux.
Links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it can't be specified dynamically, it is nice to have config files located in the ~/.config directory. This follows the standard used by many other programs and prevents the homedir from getting unreasonably cluttered with configs.
Docs still need to be updated if you decide to merge this. You might also want to check the current location for backwards compatibility--I'm happy to make these changes if you are open to the idea in the first place.