Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Action to Run Pytest for push/pull-request Actions #23

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

engineerjoe440
Copy link
Collaborator

Changes:

  • Add .github/workflows/pytest.yml to define the installation of dependencies and execution of pytest to validate behavior.

Closing thoughts:

I'm loving what you've got here in this project, and I want to use it in some of my work, but to do that, I need to enhance a few things. Before I start with too much of that, I wanted to bring in some automated testing to validate changes I make, and prove them out so that you're at least somewhat confident that my changes won't destroy your work.

Copy link
Owner

@klauer klauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been meaning to set CI up but hadn't gotten around to it. Thanks for taking care of it, @engineerjoe440!

(And also for being my first collaborator 🥳 )

@klauer klauer merged commit 30e9e4d into klauer:master Apr 19, 2022
@engineerjoe440
Copy link
Collaborator Author

Thanks for being willing to allow contributions! If you're willing, I might add a few more CI plans for flake8 (since you pointed it out in the other PR I have open), and anything else I can! :)

@klauer
Copy link
Owner

klauer commented Apr 19, 2022

Sure - that'd be great!

Just a thought, but you might consider just having pre-commit do the heavy lifting in CI (e.g., pre-commit run --all-files) instead of piece-meal flake8, isort --check-only, etc.

@engineerjoe440 engineerjoe440 deleted the maintenence/add-pytest-gh-action branch April 19, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants