Enhancement/support and then and or else operators #25
Conversation
There was a problem hiding this comment.
I appreciate the documentation links - these are new to me. I think for future grammar contributions, it'd be wise to require references to infosys documentation.
Goodness, I feel terrible, swamping your inbox with all of these PR's in rapid succession! I will say, though, that I'm finding it devilishly easy to integrate your work into a custom SEL parser, and I feel like I'm starting to get the hang of the code-structure here. Thank you for your hard work!
Please don't feel bad! This is another excellent addition and much appreciated. I'm glad you're finding the structure here to be pretty intuitive.
Test coverage looks good. This looks ready to merge on my end, if you are done with it.
|
Yep! Ready on my end! :) Thank you! |
engineerjoe440
deleted the
enhancement/support-and_then-and-or_else-operators
branch
Changes:
AND_THENandOR_ELSEoperators:Closing Thoughts:
Goodness, I feel terrible, swamping your inbox with all of these PR's in rapid succession! I will say, though, that I'm finding it devilishly easy to integrate your work into a custom SEL parser, and I feel like I'm starting to get the hang of the code-structure here. Thank you for your hard work!
Please let me know if there's anything that I'm doing that is not in line with your goals for this project. I really want to make sure that I'm not doing anything that goes against your objectives, or is disruptive to your work.