Bugfix/Enhancement: Add Support of bit_string_literal in CASE Statements
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauer
requested changes
May 12, 2022
There was a problem hiding this comment.
One minor thing. Thanks for catching this and the fix!
This still may be better enhanced by including boolean_literal, but I'm not quite sure of that.
If Codesys/TwinCAT allow for it, blark should support it - that's my take as you know. It'd be weird to use a CASE statement when an IF statement is sufficient for a boolean check, but it wouldn't surprise me if it were valid given the other things in the language...
|
I think this should be ready for another pass at your leisure. 😄 |
|
Thanks @klauer, should be ready with the new test! |
|
GitHub won't let me give bonus points for extra effort - so an emoji will have to suffice: 🎉 Thanks! |
engineerjoe440
deleted the
bugfix/address-commas-in-case-statement-failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
bit_string_literalto list ofcase_list_elementsBYTE#...Issues Addressed:
BYTE#literals not properly handled inCASEstatement #34Closing Thoughts:
This still may be better enhanced by including
boolean_literal, but I'm not quite sure of that.