Enhancements and Fixes Found While Testing Code Base #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't forgotten about this - it's still on my TODO list. To your question, I'm OK with bunching these changes into one PR. Hope to get back to you soon, and thanks! 👍 |
|
Don't worry about it! Heh! I wouldn't have been able to do anything this week if you asked for changes, anyway! Thank you! |
klauer
requested changes
May 24, 2022
…s://github.com/engineerjoe440/blark into enhancement/allow-optional-seconds-in-datetime
klauer
approved these changes
May 25, 2022
There was a problem hiding this comment.
Thank you, @engineerjoe440!
I think another tag will be in order soon with all of these nice fixes.
|
Woo-Hoo!!! Thank you @klauer !!!!! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found a number of little things that were causing some trouble while I was testing this project against a number of 61131 repositories, I've made a bunch of smaller, incremental branches for each stage of work, so if you'd prefer going through one at a time, let me know!
Changes:
Closing Thoughts:
Please do let me know if you'd rather take a piecemeal approach to this, I've still got all of the branches, and we can work each one in separately. If there's anything that I've missed (clearly I've done that a time or two before), please let me know! I'm happy to get this all cleaned up.
I'm finding this project very useful, thank you!