Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: test coverage and dropping support for lark < 1.0 #39

Merged
merged 12 commits into from
May 27, 2022
Merged

Maintenance: test coverage and dropping support for lark < 1.0 #39

merged 12 commits into from
May 27, 2022

Conversation

klauer
Copy link
Owner

@klauer klauer commented May 27, 2022 •
edited
Loading

  • All but 20ish lines in blark.transform are covered
  • The rest of the codebase isn't in such good shape, but I'll get around to it at some point
  • Dropping support for old versions of lark as the added per-version conditionals in the code are confusing/unnecessary
  • Some things were cleaned (unused InitializedStructureTypeDeclaration)
  • Unreachable code was removed
  • VAR_STAT dataclass was fixed (this was entirely broken)

Another TODO item: add pytest-cov to the GH actions and get coverage reports in PRs

@klauer klauer merged commit 6044a3b into master May 27, 2022
@klauer klauer deleted the tst_coverage branch May 27, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@klauer