Support arrays of arrays #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #66 +/- ##
========================================
- Coverage 72.7% 72.5% -0.3%
========================================
Files 18 18
Lines 3814 3816 +2
========================================
- Hits 2774 2767 -7
- Misses 1040 1049 +9
|
klauer
approved these changes
May 8, 2023
There was a problem hiding this comment.
This looks great! Thanks as usual, @engineerjoe440.
I'll merge and then we can move over to the other PR.
| @@ -1175,6 +1175,8 @@ def base_type_name(self) -> Union[str, lark.Token]: | |||
| """The base type name.""" | |||
| if isinstance(self.type, DataType): | |||
| return self.type.type_name | |||
| if isinstance(self.type, ArraySpecification): | |||
| return self.type.base_type_name | |||
There was a problem hiding this comment.
Glad you caught this one and added the test! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Changes
Closing Thoughts
I think this one should be pretty simple. I'm thankful for that! No rush to get this merged in (please enjoy your time away and don't review until you return).