Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: function call chaining in expressions #94

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

klauer
Copy link
Owner

@klauer klauer commented Nov 7, 2023

Closes #93

  • Expressions may include chained function calls
  • Prior to this PR, only statements defined in such a way were supported
  • Adds chained_function_call grammar rule and ChainedFunctionCall class

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Merging #94 (7b1a286) into master (f0783f5) will increase coverage by 0.0%.
Report is 1 commits behind head on master.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #94   +/-   ##
======================================
  Coverage    81.5%   81.6%           
======================================
  Files          27      27           
  Lines        5819    5829   +10     
======================================
+ Hits         4747    4757   +10     
  Misses       1072    1072           
Files Coverage Δ
blark/tests/test_transformer.py 94.7% <ø> (ø)
blark/transform.py 98.3% <100.0%> (+<0.1%) ⬆️

@klauer klauer marked this pull request as ready for review November 7, 2023 18:00
Copy link
Collaborator

@engineerjoe440 engineerjoe440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirmed with the source code that this issue popped up on. This does, in fact, resolve the issue! Wonderful! Thank you!!!!

🎉

@engineerjoe440 engineerjoe440 merged commit 5e20aa3 into master Nov 7, 2023
26 checks passed
@engineerjoe440 engineerjoe440 deleted the fix_chain_expression branch November 7, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax Parsing Failure - Accessing an Attribute on a Dereferenced Pointer Returned from a Method Doesn't Work
3 participants