Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: init arguments for pointer type specifications #95

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

klauer
Copy link
Owner

@klauer klauer commented Nov 17, 2023

Closes #85

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

Merging #95 (2250af6) into master (5e20aa3) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #95     +/-   ##
========================================
+ Coverage    81.4%   81.6%   +0.1%     
========================================
  Files          27      27             
  Lines        5829    5838      +9     
========================================
+ Hits         4748    4766     +18     
+ Misses       1081    1072      -9     
Files Coverage Δ
blark/tests/test_transformer.py 94.7% <ø> (ø)
blark/transform.py 98.3% <100.0%> (+<0.1%) ⬆️

... and 1 file with indirect coverage changes

@klauer klauer marked this pull request as ready for review November 17, 2023 18:53
@klauer
Copy link
Owner Author

klauer commented Nov 17, 2023

Mind taking a look and giving this a shot with your code, @engineerjoe440?

@klauer
Copy link
Owner Author

klauer commented Nov 21, 2023

I'll push this through as it's either "release today or not for a long while"

🤞 this should fix the original issue...

@klauer klauer merged commit 4d5c905 into master Nov 21, 2023
26 checks passed
@klauer klauer deleted the fix_pointer_init branch November 21, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to Parse POINTER TO Object using FB_Init
2 participants