Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zstd: BuildDict fails with RLE table #951

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

klauspost
Copy link
Owner

@klauspost klauspost commented Apr 12, 2024

We cannot build a useable table if RLE. Add a fake entry to generate valid tables.

Invalid offsets could be generated.

Fixes #950

We cannot build a useable table if RLE. Add a fake entry to generate valid tables.
@klauspost klauspost mentioned this pull request Apr 12, 2024
@klauspost klauspost merged commit 0396178 into master Jun 12, 2024
18 checks passed
@klauspost klauspost deleted the zstd-dict-rle-tables branch June 12, 2024 08:42
MrAlias referenced this pull request in open-telemetry/opentelemetry-go-contrib Jun 17, 2024
…5760)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/klauspost/compress](https://github.com/klauspost/compress)
| `v1.17.8` -> `v1.17.9` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fklauspost%2fcompress/v1.17.9?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fklauspost%2fcompress/v1.17.9?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fklauspost%2fcompress/v1.17.8/v1.17.9?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fklauspost%2fcompress/v1.17.8/v1.17.9?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>klauspost/compress (github.com/klauspost/compress)</summary>

###
[`v1.17.9`](https://github.com/klauspost/compress/releases/tag/v1.17.9)

[Compare
Source](https://github.com/klauspost/compress/compare/v1.17.8...v1.17.9)

##### What's Changed

- s2: Reduce ReadFrom temporary allocations by
[@&#8203;klauspost](https://github.com/klauspost) in
[https://github.com/klauspost/compress/pull/949](https://github.com/klauspost/compress/pull/949)
- Fix arm64 vet issues by
[@&#8203;klauspost](https://github.com/klauspost) in
[https://github.com/klauspost/compress/pull/964](https://github.com/klauspost/compress/pull/964)
- flate, zstd: Shave some bytes off amd64 matchLen by
[@&#8203;greatroar](https://github.com/greatroar) in
[https://github.com/klauspost/compress/pull/963](https://github.com/klauspost/compress/pull/963)
- Upgrade zip to 1.22.4 upstream by
[@&#8203;klauspost](https://github.com/klauspost) in
[https://github.com/klauspost/compress/pull/970](https://github.com/klauspost/compress/pull/970)
- zstd: BuildDict fails with RLE table by
[@&#8203;klauspost](https://github.com/klauspost) in
[https://github.com/klauspost/compress/pull/951](https://github.com/klauspost/compress/pull/951)
- Upgrade zlib to upstream by
[@&#8203;klauspost](https://github.com/klauspost) in
[https://github.com/klauspost/compress/pull/971](https://github.com/klauspost/compress/pull/971)

**Full Changelog**:
klauspost/compress@v1.17.8...v1.17.9

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-go-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJTa2lwIENoYW5nZWxvZyIsImRlcGVuZGVuY2llcyJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
codeboten referenced this pull request in open-telemetry/opentelemetry-collector Jun 18, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/klauspost/compress](https://github.com/klauspost/compress)
| `v1.17.8` -> `v1.17.9` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fklauspost%2fcompress/v1.17.9?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fklauspost%2fcompress/v1.17.9?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fklauspost%2fcompress/v1.17.8/v1.17.9?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fklauspost%2fcompress/v1.17.8/v1.17.9?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>klauspost/compress (github.com/klauspost/compress)</summary>

###
[`v1.17.9`](https://github.com/klauspost/compress/releases/tag/v1.17.9)

[Compare
Source](https://github.com/klauspost/compress/compare/v1.17.8...v1.17.9)

##### What's Changed

- s2: Reduce ReadFrom temporary allocations by
[@&#8203;klauspost](https://github.com/klauspost) in
[https://github.com/klauspost/compress/pull/949](https://github.com/klauspost/compress/pull/949)
- Fix arm64 vet issues by
[@&#8203;klauspost](https://github.com/klauspost) in
[https://github.com/klauspost/compress/pull/964](https://github.com/klauspost/compress/pull/964)
- flate, zstd: Shave some bytes off amd64 matchLen by
[@&#8203;greatroar](https://github.com/greatroar) in
[https://github.com/klauspost/compress/pull/963](https://github.com/klauspost/compress/pull/963)
- Upgrade zip to 1.22.4 upstream by
[@&#8203;klauspost](https://github.com/klauspost) in
[https://github.com/klauspost/compress/pull/970](https://github.com/klauspost/compress/pull/970)
- zstd: BuildDict fails with RLE table by
[@&#8203;klauspost](https://github.com/klauspost) in
[https://github.com/klauspost/compress/pull/951](https://github.com/klauspost/compress/pull/951)
- Upgrade zlib to upstream by
[@&#8203;klauspost](https://github.com/klauspost) in
[https://github.com/klauspost/compress/pull/971](https://github.com/klauspost/compress/pull/971)

**Full Changelog**:
klauspost/compress@v1.17.8...v1.17.9

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
dmitryax referenced this pull request in open-telemetry/opentelemetry-collector-contrib Jun 19, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/klauspost/compress](https://github.com/klauspost/compress)
| `v1.17.8` -> `v1.17.9` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fklauspost%2fcompress/v1.17.9?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fklauspost%2fcompress/v1.17.9?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fklauspost%2fcompress/v1.17.8/v1.17.9?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fklauspost%2fcompress/v1.17.8/v1.17.9?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>klauspost/compress (github.com/klauspost/compress)</summary>

###
[`v1.17.9`](https://github.com/klauspost/compress/releases/tag/v1.17.9)

[Compare
Source](https://github.com/klauspost/compress/compare/v1.17.8...v1.17.9)

##### What's Changed

- s2: Reduce ReadFrom temporary allocations by
[@&#8203;klauspost](https://github.com/klauspost) in
[https://github.com/klauspost/compress/pull/949](https://github.com/klauspost/compress/pull/949)
- Fix arm64 vet issues by
[@&#8203;klauspost](https://github.com/klauspost) in
[https://github.com/klauspost/compress/pull/964](https://github.com/klauspost/compress/pull/964)
- flate, zstd: Shave some bytes off amd64 matchLen by
[@&#8203;greatroar](https://github.com/greatroar) in
[https://github.com/klauspost/compress/pull/963](https://github.com/klauspost/compress/pull/963)
- Upgrade zip to 1.22.4 upstream by
[@&#8203;klauspost](https://github.com/klauspost) in
[https://github.com/klauspost/compress/pull/970](https://github.com/klauspost/compress/pull/970)
- zstd: BuildDict fails with RLE table by
[@&#8203;klauspost](https://github.com/klauspost) in
[https://github.com/klauspost/compress/pull/951](https://github.com/klauspost/compress/pull/951)
- Upgrade zlib to upstream by
[@&#8203;klauspost](https://github.com/klauspost) in
[https://github.com/klauspost/compress/pull/971](https://github.com/klauspost/compress/pull/971)

**Full Changelog**:
klauspost/compress@v1.17.8...v1.17.9

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BuildZStdDict Testing
1 participant