Darwin L1 Data Cache fix #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that the struct members for the L1 cache match the values provided by the OS sysctl utility
|
@klauspost For your review, per your comment. |
klauspost
approved these changes
Nov 8, 2022
kodiakhq bot
referenced
this pull request
in cloudquery/filetypes
Apr 1, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/klauspost/cpuid/v2](https://togithub.com/klauspost/cpuid) | indirect | minor | `v2.1.0` -> `v2.2.4` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>klauspost/cpuid</summary> ### [`v2.2.4`](https://togithub.com/klauspost/cpuid/releases/tag/v2.2.4) [Compare Source](https://togithub.com/klauspost/cpuid/compare/v2.2.3...v2.2.4) #### What's Changed - Add more Intel mitigation flags by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/cpuid/pull/128](https://togithub.com/klauspost/cpuid/pull/128) - Add more Intel Sierra Forest instructions by [@​fmuyassarov](https://togithub.com/fmuyassarov) in [https://github.com/klauspost/cpuid/pull/129](https://togithub.com/klauspost/cpuid/pull/129) **Full Changelog**: klauspost/cpuid@v2.2.3...v2.2.4 ### [`v2.2.3`](https://togithub.com/klauspost/cpuid/releases/tag/v2.2.3) [Compare Source](https://togithub.com/klauspost/cpuid/compare/v2.2.2...v2.2.3) #### What's Changed - docs: add homebrew installation note by [@​chenrui333](https://togithub.com/chenrui333) in [https://github.com/klauspost/cpuid/pull/126](https://togithub.com/klauspost/cpuid/pull/126) - Add Intel Sierra Forest instructions by [@​fmuyassarov](https://togithub.com/fmuyassarov) in [https://github.com/klauspost/cpuid/pull/127](https://togithub.com/klauspost/cpuid/pull/127) #### New Contributors - [@​chenrui333](https://togithub.com/chenrui333) made their first contribution in [https://github.com/klauspost/cpuid/pull/126](https://togithub.com/klauspost/cpuid/pull/126) **Full Changelog**: klauspost/cpuid@v2.2.2...v2.2.3 ### [`v2.2.2`](https://togithub.com/klauspost/cpuid/releases/tag/v2.2.2) [Compare Source](https://togithub.com/klauspost/cpuid/compare/v2.2.1...v2.2.2) #### What's Changed - Add Intel Granite Rapid features by [@​fmuyassarov](https://togithub.com/fmuyassarov) in [https://github.com/klauspost/cpuid/pull/125](https://togithub.com/klauspost/cpuid/pull/125) #### New Contributors - [@​fmuyassarov](https://togithub.com/fmuyassarov) made their first contribution in [https://github.com/klauspost/cpuid/pull/125](https://togithub.com/klauspost/cpuid/pull/125) **Full Changelog**: klauspost/cpuid@v2.2.1...v2.2.2 ### [`v2.2.1`](https://togithub.com/klauspost/cpuid/releases/tag/v2.2.1) [Compare Source](https://togithub.com/klauspost/cpuid/compare/v2.2.0...v2.2.1) #### What's Changed - Add more AMD flags by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/cpuid/pull/123](https://togithub.com/klauspost/cpuid/pull/123) - Fix microarch level by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/cpuid/pull/124](https://togithub.com/klauspost/cpuid/pull/124) **Full Changelog**: klauspost/cpuid@v2.2.0...v2.2.1 ### [`v2.2.0`](https://togithub.com/klauspost/cpuid/releases/tag/v2.2.0) [Compare Source](https://togithub.com/klauspost/cpuid/compare/v2.1.2...v2.2.0) #### What's Changed - Add CombineFeatures for faster lookups. by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/cpuid/pull/120](https://togithub.com/klauspost/cpuid/pull/120) - Darwin L1 Data Cache fix by [@​ironiridis](https://togithub.com/ironiridis) in [https://github.com/klauspost/cpuid/pull/122](https://togithub.com/klauspost/cpuid/pull/122) #### New Contributors - [@​ironiridis](https://togithub.com/ironiridis) made their first contribution in [https://github.com/klauspost/cpuid/pull/122](https://togithub.com/klauspost/cpuid/pull/122) **Full Changelog**: klauspost/cpuid@v2.1.2...v2.2.0 ### [`v2.1.2`](https://togithub.com/klauspost/cpuid/releases/tag/v2.1.2) [Compare Source](https://togithub.com/klauspost/cpuid/compare/v2.1.1...v2.1.2) #### What's Changed - Add some Intel flags by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/cpuid/pull/119](https://togithub.com/klauspost/cpuid/pull/119) **Full Changelog**: klauspost/cpuid@v2.1.1...v2.1.2 ### [`v2.1.1`](https://togithub.com/klauspost/cpuid/releases/tag/v2.1.1) [Compare Source](https://togithub.com/klauspost/cpuid/compare/v2.1.0...v2.1.1) #### What's Changed - Add CPU Stepping by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/cpuid/pull/112](https://togithub.com/klauspost/cpuid/pull/112) - Code consistency by [@​fpelliccioni](https://togithub.com/fpelliccioni) in [https://github.com/klauspost/cpuid/pull/114](https://togithub.com/klauspost/cpuid/pull/114) - Remove SCE by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/cpuid/pull/115](https://togithub.com/klauspost/cpuid/pull/115) - Fixes MMXEXT by [@​fpelliccioni](https://togithub.com/fpelliccioni) in [https://github.com/klauspost/cpuid/pull/116](https://togithub.com/klauspost/cpuid/pull/116) - Skip AMD leaf 0x8000001d parsing if no TOPEXT by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/cpuid/pull/118](https://togithub.com/klauspost/cpuid/pull/118) #### New Contributors - [@​fpelliccioni](https://togithub.com/fpelliccioni) made their first contribution in [https://github.com/klauspost/cpuid/pull/114](https://togithub.com/klauspost/cpuid/pull/114) **Full Changelog**: klauspost/cpuid@v2.1.0...v2.1.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTQuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE1NC4wIn0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears there was a copy-paste error when implementing the L1 icache and dcache detection for Apple's silicon. This PR includes a test that detects the discrepancy and the fix.
Fixes #121