Refactor: Fix name conflict of struct Dispute and event Dispute #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This name conflict becomes a problem when both CentralizedArbitrator and Arbitrable contracts inherited, which is required in AppealableArbitrator.
0xferit
changed the title
|
Events can't be renamed because some code depends of it. |
clesaege
previously requested changes
Aug 7, 2018
added 2 commits
August 7, 2018 17:14
0xferit
dismissed
clesaege’s stale review
I reverted the fix and proposed another one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This name conflict becomes a problem when both
CentralizedArbitrator(hasstruct Dispute) andArbitrable(hasevent Dispute) contracts inherited, which is required inAppealableArbitrator. Discovered this while working on #3.So following contract doesn't compile:
To fix it I renamed
event Disputetoevent DisputeCreatedinArbitrablebut maybe you can find a better name.