refactor: refactor overlay module

klinecharts · Jun 7, 2024 · 0459735 · 0459735
1 parent b2688b9
commit 0459735
Show file tree

Hide file tree

Showing 8 changed files with 230 additions and 504 deletions.
diff --git a/src/Chart.ts b/src/Chart.ts
@@ -712,7 +712,7 @@ export default class ChartImp implements Chart {
 
   createIndicator (value: string | IndicatorCreate, isStack?: boolean, paneOptions?: Nullable<PaneOptions>, callback?: () => void): Nullable<string> {
     const indicator = isString(value) ? { name: value } : value
-    if (getIndicatorClass(indicator.name as string) === null) {
+    if (getIndicatorClass(indicator.name) === null) {
       logWarn('createIndicator', 'value', 'indicator not supported, you may need to use registerIndicator to add one!!!')
       return null
     }
@@ -820,7 +820,7 @@ export default class ChartImp implements Chart {
   }
 
   getOverlayById (id: string): Nullable<Overlay> {
-    return this._chartStore.getOverlayStore().getInstanceById(id)
+    return this._chartStore.getOverlayStore().getInstanceById(id)?.getOverlay() ?? null
   }
 
   overrideOverlay (override: Partial<OverlayCreate>): void {

diff --git a/src/component/Indicator.ts b/src/component/Indicator.ts
@@ -218,11 +218,6 @@ export interface Indicator<D = any> {
    * Calculation result
    */
   result: D[]
-
-  /**
-   * Others
-   */
-  [key: string]: any
 }
 
 export type IndicatorTemplate<D = any> = ExcludePickPartial<Omit<Indicator<D>, 'result'>, 'name' | 'calc'>