Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OkHttp 4.10 -> 4.12 #103

Open
vpiskunov opened this issue Jan 11, 2024 · 0 comments · May be fixed by #104
Open

Update OkHttp 4.10 -> 4.12 #103

vpiskunov opened this issue Jan 11, 2024 · 0 comments · May be fixed by #104

Comments

@vpiskunov
Copy link

Hi! 👋

Discovered an issue where requests in Android fail with a okhttp3.internal.http2.StreamResetException: stream was reset: INTERNAL_ERROR

Now, this is mentioned here as a server side issue - however in my case (and some of other people), the error did not occur on normal browsers nor in Postman etc.

Using a later version of OkHTTP seems to have solved this however!

Smallest diff ever below:

diff --git a/node_modules/@klippa/nativescript-http/platforms/android/include.gradle b/node_modules/@klippa/nativescript-http/platforms/android/include.gradle
index f94d213..9fffe42 100644
--- a/node_modules/@klippa/nativescript-http/platforms/android/include.gradle
+++ b/node_modules/@klippa/nativescript-http/platforms/android/include.gradle
@@ -5,5 +5,5 @@ android {
 }
 
 dependencies {
-    implementation "com.squareup.okhttp3:okhttp:4.10.+"
+    implementation "com.squareup.okhttp3:okhttp:4.12.+"
 }

This issue body was partially generated by patch-package.

vpiskunov added a commit to vpiskunov/nativescript-http that referenced this issue Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant