Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump deepmerge dependency fixing optimistic updates #25

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

haddowg
Copy link

@haddowg haddowg commented Jul 11, 2024

Bump to use the latest deepmerge, I have kept this pinned to latest rather than using ^ as this was the existing convention.

Specifically, this will resolve an issue I experienced with optimistic updates of objects with falsey values fixed in 4.2.1, see
TehShrike/deepmerge#172

@haddowg haddowg changed the title chore: bump deepmerge dependency chore: bump deepmerge dependency fixing optimistic updates Jul 11, 2024
@haddowg haddowg changed the title chore: bump deepmerge dependency fixing optimistic updates fix: bump deepmerge dependency fixing optimistic updates Jul 11, 2024
@klis87
Copy link
Owner

klis87 commented Jul 11, 2024

Thanks, I will take a look later hopefully today, that it does not break any tests. I must really setup CI btw :)

@klis87
Copy link
Owner

klis87 commented Jul 11, 2024

Is it possible also for you to give me the code snippet which actually failed? So I will write regression test

@klis87 klis87 merged commit 28cb247 into klis87:master Jul 15, 2024
@haddowg haddowg deleted the chore/deepmerge branch July 16, 2024 06:50
@klis87
Copy link
Owner

klis87 commented Jul 16, 2024

Merged and released yesterday, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants