fix eks bugs #838
Merged
fix eks bugs #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordon-klotho
approved these changes
Dec 20, 2023
| @@ -90,32 +90,31 @@ func ConsumeFromResource(consumer, emitter *construct.Resource, ctx DynamicConte | |||
| addErr(consume, emit, err) | |||
| continue | |||
| } | |||
| val, err = sanitizeForConsumption(ctx, resource, consumeTmpl.GetProperty(consume.PropertyPath), val) | |||
| pval, err := resource.GetProperty(consume.PropertyPath) | |||
There was a problem hiding this comment.
nit: why did this move up? pval isn't used until after converting & sanitizing so it can be done later
| @@ -177,7 +177,7 @@ func (l *ListProperty) Validate(resource *construct.Resource, value any, ctx kno | |||
|
|
|||
| listVal, ok := value.([]any) | |||
| if !ok { | |||
| return fmt.Errorf("invalid map value %v", value) | |||
| return fmt.Errorf("invalid list value %v", value) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes kubeconfig circular iac dependency and emitter bug to where we try to sanitize to the wrong type since its done before convert
Standard checks