Template Fixes for ECR and Cloudfront #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why did all the tests change? Also good catch on the cdn, i assume that fixes the not picking up POST and what not. Also i have a task assigned to me for the ecr image which you should take |
|
The expectations all needed that platform property. The other test file just have changes to resource ordering, which doesn't seem likely to be associated with this specific set of changes. |
gordon-klotho
approved these changes
Mar 6, 2024
…ister rule condition as the path the correct behavior is to pull from the same rule since you can only have one condition type per condition.
DavidSeptimus-Klotho
force-pushed
the
image-platform
branch
from
104a9bb
to
10f50f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws:ecr_imageaws:cloudfront_distribution -> aws:load_balanceredges. A given rule's paths and methods are always on different conditions. Each condition only handles one condition type.