Support multi-arch images build and push automatically #715
Conversation
…in branch and tag Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
dockerfile
Outdated
There was a problem hiding this comment.
Should i shoud put this file into build/docker
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
hzxuzhonghu
force-pushed
the
multi-arch-image
branch
from
d72ffa5 to
89cdacd
Compare
build/docker/dockerfile
Outdated
| @@ -0,0 +1,26 @@ | |||
| FROM ghcr.io/kmesh-net/kmesh-build:latest AS builder | |||
| Copy . /kmesh | |||
There was a problem hiding this comment.
| Copy . /kmesh | |
| COPY . /kmesh | |
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
| - "**/*.md" | ||
|
|
||
| tags: | ||
| - "v*.*.*" |
There was a problem hiding this comment.
Can't kmesh's TAG cancel the 'v'?
There was a problem hiding this comment.
maybe a separate issue, why strip v prefix
There was a problem hiding this comment.
Because there is a PR in the Kurator community for removing the prefix v
kurator-dev/kurator#433
There was a problem hiding this comment.
Please take alook https://github.com/orgs/kmesh-net/packages/container/package/kmesh
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlgwcy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Support multi-arch images build and push automatically for both push on main and new tag
Which issue(s) this PR fixes:
Fixes #714
Special notes for your reviewer:
Does this PR introduce a user-facing change?: