Add hypothesis strategy for testing ISO-8601 round-trip of cftime objects #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a hypothesis strategy for drawing cftime objects of any calendar type between the dates of
-99999-01-01
and99999-12-DDT23:59:59.999999
(the maximum day depends on the calendar type).cc: @dcherian
This is my first time writing a hypothesis strategy, so let me know if you have any tips / suggestions. The core of it is a bit simpler than the strategy for generating standard library
datetime.datetime
objects. I broke things up into a basic strategy—one that generates datetimes within a certain range—and one specific to the ISO-8601 round-trip test, since I can imagine use-cases where we might want to change the minimum and maximum values and / or have tighter control over the calendar.