Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade frontend JS components #369

Closed
knadh opened this issue May 23, 2021 · 1 comment
Closed

Upgrade frontend JS components #369

knadh opened this issue May 23, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@knadh
Copy link
Owner

knadh commented May 23, 2021

Ref: #339

Frontend deps node-sass and sass-loader fail to build on Node 16. It appears that upgrading these libs to run on Node 16 require Buefy (UI lib) and Vue to be upgraded. There are breaking syntactic and functional changes in the latest version of Buefy that require changes to all <b-table> implementations, of which there are many in the app. This is primarily to do with Vue 2.6's new v-slot directive.

Also, the latest version of Buefy does not seem to require any sass libs at all for customizing CSS, so it might be possible to eliminate these dependencies entirely. It's also interesting to note that the latest version of sass-loader (which does not work on Node 16) in turn recommends using dart-sass over node-sass.

Until these issues are resolved and the frontend is upgraded cleanly, it is recommended to continue using Node 14 to compile the frontend.

PS: Yet another day in the Node/JS "ecosystem" ;(

@knadh knadh added the enhancement New feature or request label May 23, 2021
@knadh knadh self-assigned this May 23, 2021
knadh added a commit that referenced this issue May 23, 2021
See issue #369

Upgrade sass libs to work with Node 16.
knadh added a commit that referenced this issue May 23, 2021
See issue #369

Upgrade sass libs to work with Node 16.
@knadh knadh changed the title WIP: Upgrade frontend JS components Upgrade frontend JS components May 23, 2021
@knadh
Copy link
Owner Author

knadh commented May 23, 2021

#371 closes this.

@knadh knadh closed this as completed May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant