Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing NO_COLOR #422

Closed
spravil opened this issue Jul 21, 2021 · 2 comments · Fixed by #423
Closed

Missing NO_COLOR #422

spravil opened this issue Jul 21, 2021 · 2 comments · Fixed by #423

Comments

@spravil
Copy link

spravil commented Jul 21, 2021

If you run the script the terminal is colored green because the NO_COLOR command is missing.

printf '%s\n' "${GREEN}${GREEN} $*"

@mr-karan
Copy link
Collaborator

Can you give more details of your environment. Particularly which OS, shell etc.

@spravil
Copy link
Author

spravil commented Jul 21, 2021

Debian 10 + PuTTY. But this is not required to replicate this issue. The other logging functions use NO_COLOR correctly.
For example:

error() {
  printf '%s\n' "${RED}x $*${NO_COLOR}" >&2
}

So

completed() {
  printf '%s\n' "${GREEN}${GREEN} $*"
}

should be

completed() {
  printf '%s\n' "${GREEN}$*${NO_COLOR}"
}

Pannigliaet added a commit to Pannigliaet/listmonk that referenced this issue Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants