Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading German translation #1115

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Fix misleading German translation #1115

merged 1 commit into from
Dec 21, 2022

Conversation

jfilter
Copy link
Contributor

@jfilter jfilter commented Dec 20, 2022

The word erfolgreich (successfully) implies the user is already confirmed, even though s/he still has to click on the confirmation link.

The word `erfolgreich` (successfully) implies the user is already confirmed, even though s/he still has to click on the confirmation link.
@NicoHood
Copy link
Contributor

But well, isnt that a general issue then, also in english?

@jfilter
Copy link
Contributor Author

jfilter commented Dec 20, 2022

The English version for public.confirmSubInfo is currently:

"You have been added to the following lists:"

It's not:

"You have been added successfully to the following lists:".

IMO, this change brings the translation closer to the original.

@NicoHood
Copy link
Contributor

alright, agree

@knadh knadh merged commit 8a2d053 into knadh:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants