-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public Archive Improvements #1262
Conversation
This is nice! Thanks @justinbeaty. Related: #1033 Yes, we should have that as a config option. Would you be able to add a commit for that or would you want me to? We've to:
|
Thanks for the list of TODO, I can add the commit. |
Added the config option with default value |
I've pushed this code to production for a few days now and all seems well. I've been testing the public rss feed with inoreader.com. |
Thanks @justinbeaty. Will review this and merge this in the coming few days. |
Add the missing `archive` context in all language strings and field names related to public archive settings. - This introduces breaking changes to the database settings key. `enable_rss_content` to `enable_public_archive_rss_content`. - Tweaks i18n strings. - Adds missing `enable_public_archive_rss_content` key in installation schema.
Hi @justinbeaty. I've pushed a couple of commits with minor changes. Can you review? |
Fixed a typo in I will test this out today. For my own reference, I ran these postgres queries so I can re-run the update process: update settings set value = '["v1.0.0", "v2.0.0", "v2.1.0", "v2.2.0", "v2.3.0", "v2.4.0"]' where key = 'migrations';
delete from settings where key = 'app.enable_rss_content'; |
@knadh |
Thank you once again for the excellent PR @justinbeaty! |
Thanks for this! Are you planning on tagging a new release in the near future? |
This PR does two things. I can split into separate PRs if requested.
example.com/archive/latest
page that renders the most recent newsletter.<content:encoded>
element into the RSS feed. (Fixes Campaign body in RSS feed #1033)For item 2, perhaps we should add a config option for this? Something like this (mockup):
Note: I did have to add complexity to the
get-archived-campaigns
query, which I think is an acceptable trade off and it makes the function's description more accurate:listmonk/internal/core/campaigns.go
Lines 140 to 141 in 684c15a