-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add multiarch docker build support #1344
Conversation
adds docker build support for the following platforms: - amd64 (default) - arm64v8 - armv6 - armv7 also adds GOOS and GOARCH information to the buildString utilizes docker manifest to store image architecture metadata
This is desperately needed :) Thanks for the PR. Wanted to do the exact same thing <3 Can we have this merged soon? |
Done. Thanks @Thunderbottom! |
Neat. One quick question. I am not seeing auto-releases for main pushes. Only for Thanks a bunch @knadh for this great piece. |
Hi @activenode. I don't think it's ideal for the entire package to be built and pushed on every commit, where some commits may be trivial. A better approach would be to have an automated monthly RC release or something along those lines. |
Sure that's fine. I just wanted to ask basically when the next version release is expected. Until then I can build it on my own, all good |
Adding to what @activenode asked. @knadh is there any schedule for the release? I am so eager to try listmonk on my ARM VPS. Great project by the way. Thank you all for contributing to it. |
@dandry I created an arm64 build because I wouldn't want to wait. If you wanna try it. It's the exact latest version. https://hub.docker.com/repository/docker/activenode/listmonk-arm64/tags?page=1&ordering=last_updated |
@activenode thank you, will give it a try! |
Coming back to this thread, I was forking the newest main and seeing that I'm working on that in my fork and will provide a PR back. |
Little Update: I'm still working on my branch, multiple errors occur of which one is that syscall.Utsname isn't available on all platforms. I am trying to find a more fitting/generic solution |
(also @dandry I have now recreated all builds until my new PR is properly merged so feel free to use https://hub.docker.com/r/activenode/listmonk/tags) |
GOOS
andGOARCH
information to thebuildString
docker/login-action
fromv1
tov2
goreleaser/goreleaser-action
fromv2
tov4
Tested the images locally, built with
goreleaser
and seems to be working fine. Screenshots:Build Images
Running Containers
Container Binary Build Info