Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: campaign field names #306

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Conversation

kousikmitra
Copy link
Contributor

@kousikmitra kousikmitra commented Mar 30, 2021

Issue:

image

  1. Added : for placeholder property
  2. Added rawHTML under fields namespace
    <b-field :label="$t('globals.fields.rawHTML')" label-position="on-border">

@knadh
Copy link
Owner

knadh commented Apr 1, 2021

Thanks @kousikmitra. The rawHTML field should not be in globals though, but campaigns, as it's used in just a couple places. I think this is already fixed in the testing branch. Could you compare with that and amend?

@kousikmitra kousikmitra changed the base branch from master to testing April 1, 2021 12:04
@kousikmitra
Copy link
Contributor Author

Thanks @kousikmitra. The rawHTML field should not be in globals though, but campaigns, as it's used in just a couple places. I think this is already fixed in the testing branch. Could you compare with that and amend?

Changed the base to testing, its not changed yet. Will change it to globals.campaigns.rawHTML

@knadh
Copy link
Owner

knadh commented Apr 1, 2021

It shouldn't be globals at all. It's already present here:

"campaigns.rawHTML": "Raw HTML",

"templates.rawHTML": "Raw HTML"

@kousikmitra
Copy link
Contributor Author

fixed it.

@kousikmitra kousikmitra changed the base branch from testing to master April 1, 2021 14:16
@knadh knadh merged commit e7e36a0 into knadh:master Apr 2, 2021
@kousikmitra kousikmitra deleted the fix/campaign-field-names branch April 3, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants