Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle sprig template functions #309

Merged
merged 1 commit into from
Apr 11, 2021
Merged

Bundle sprig template functions #309

merged 1 commit into from
Apr 11, 2021

Conversation

tamalsaha
Copy link
Contributor

Signed-off-by: Tamal Saha tamal@appscode.com

@tamalsaha
Copy link
Contributor Author

I think it will useful to have these functions available to generate templates. https://github.com/Masterminds/sprig/blob/master/docs/index.md

Signed-off-by: Tamal Saha <tamal@appscode.com>
@knadh
Copy link
Owner

knadh commented Apr 11, 2021

Didn't know about sprig. This is very useful. Adding the map on every compilation allocates a bunch and adds an average ~150μs just to the template func construction (got curious and checked), but that's negligible compared to the actual I/O bottleneck of messages. Merging this. Thanks.

@knadh knadh merged commit bc8b4d0 into knadh:master Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants