Replace Quill editor with TinyMCE #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Pushed a few changes and bug fixes. For language packs, for every i18n language pack listmonk supports, we'll have to manually download the corresponding TinyMCE language pack and commit it to the repo and use a |
- Moved the init event to init_instance_callback() from @init event which doesn't fire. - Add watcher for form.body to fire onEditorChange event. This fixes TinyMCE editor changes not getting saved.
- Load bundled TinyMCE i18n language file based on a listmonk -> TinyMCE map. - Refactor editor initialisation to accommodate this change. - Introduce `constants.js -> uris.static` to make the static URI available to TinyMCE for loading language files.
knadh
force-pushed
the
feature/replace-quill-with-tinymce
branch
from
e2bbfea
to
68512d2
Compare
|
@henk23 thanks for this PR and also for kick starting this in the first place. This is a valuable change for listmonk. 🎉 |
|
Happy to help. :) I don't often contribute to FOSS, but when I do, it's completely selfish. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to serve as a proof of concept and not ready for production
Description
This PR is a proof of concept of replacing Quill editor with TinyMCE. Context: Issue #467
Caveats