Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provision delivery format in contract #3987

Conversation

Cali0707
Copy link
Member

Fixes #3970

Proposed Changes

  • Add the format field to the egress config

@knative-prow knative-prow bot requested review from creydr and pierDipi July 12, 2024 16:40
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/data-plane labels Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 5.12821% with 37 lines in your changes missing coverage. Please review.

Project coverage is 48.27%. Comparing base (dcb704a) to head (d4d2007).
Report is 1 commits behind head on main.

Files Patch % Lines
control-plane/pkg/contract/contract.pb.go 3.12% 31 Missing ⚠️
control-plane/pkg/core/config/utils.go 14.28% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3987      +/-   ##
==========================================
- Coverage   48.33%   48.27%   -0.07%     
==========================================
  Files         244      244              
  Lines       14579    14600      +21     
==========================================
+ Hits         7047     7048       +1     
- Misses       6821     6840      +19     
- Partials      711      712       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matzew
Copy link
Contributor

matzew commented Jul 15, 2024

/test upgrade-tests

Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707 Cali0707 force-pushed the provision-delivery-format-in-contract branch from 57df63b to aa4efb2 Compare July 15, 2024 13:21
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 15, 2024
@Cali0707
Copy link
Member Author

@matzew I've rebased this to only have the relevant changes, can you recheck?

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
Copy link

knative-prow bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Contributor

matzew commented Jul 16, 2024

/retest-required

@matzew
Copy link
Contributor

matzew commented Jul 16, 2024

/retest

@Cali0707
Copy link
Member Author

/retest-required

1 similar comment
@Cali0707
Copy link
Member Author

/retest-required

@Cali0707
Copy link
Member Author

/test upgrade-tests

Copy link

knative-prow bot commented Jul 17, 2024

New changes are detected. LGTM label has been removed.

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2024
@Cali0707
Copy link
Member Author

/cc @matzew

While going through the data plane changes I realized I needed to essentially re-do the changes in this PR so since the data plane changes are isolated I added them here as well instead

I'll add unit tests and an e2e test later, would you mind taking a look at the data plane code and letting me know if the approach I'm taking makes sense?

@knative-prow knative-prow bot requested a review from matzew July 17, 2024 17:13
Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707 Cali0707 force-pushed the provision-delivery-format-in-contract branch from d0a7395 to 6d2d475 Compare July 17, 2024 17:22
@Cali0707
Copy link
Member Author

/cc @pierDipi

@pierDipi
Copy link
Member

pierDipi commented Aug 6, 2024

/retest

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2024
Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 19, 2024
Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2024
@Cali0707
Copy link
Member Author

/retest-required

Copy link

knative-prow bot commented Aug 19, 2024

@Cali0707: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
upgrade-tests_eventing-kafka-broker_main 9904915 link true /test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 21, 2024
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 20, 2024
@github-actions github-actions bot closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/data-plane lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delivery format: add and provision format field to EgressConfig in contract
4 participants